# Tag Event Scripts on Value Changed slow execution time **URL:** \ **Category:** Ignition\ **Tags:** scripting\ **Created:** [April 29, 2022, 9:13am UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040 "2022-04-29T09:13:43Z")\ **Posts on this page:** 8\ **Page:** 1
**Author:** ![T\_Hat](https://avatars.discourse-cdn.com/v4/letter/t/df705f/32.png) [@T\_Hat](https://forum.inductiveautomation.com/u/T_Hat)\ **Post date:** [April 29, 2022, 9:13am UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040/1 "2022-04-29T09:13:43Z")
Im using tag event scripting for communication between PLC and Manufacturing Execution System which is using Oracle DataBase. The sctript is realy simple, yet it takes about 400ms to execute. ![image](https://us1.discourse-cdn.com/inductiveautomation/original/3X/5/7/57abd3b1d48fbdce0ffacdda51df63966664d02f.png) Script starts when Tag WriteRequest gets value 1 from PLC. ``` wert = system.tag.readBlocking(["[default]St70/Pm701/ST70_PM701_PRODUCTPACKING.value"])[0].value #Telegram ready to be sent to the MES prod = system.tag.readBlocking(["[default]St70/Pm701/PisanieDoBazyProdukcyjnej.value"])[0].value #Sending signals to the production DB test = system.tag.readBlocking(["[default]St70/Pm701/PisanieDoBazyTestowej.value"])[0].value #Sending signals to the test DB testConnection = system.tag.readBlocking(["[default]AvailabilityDBTest.value"])[0].value #Connection with test DB prodConnection = system.tag.readBlocking(["[default]AvailabilityDBProd.value"])[0].value #Connection with production DB if currentValue.value == 1: #Signal for sending a telegram to the database if test == 1 and testConnection == 1: #Are we writing to the test base and is there a connection to the test base system.db.runUpdateQuery("INSERT INTO QMES_QOPC_IMPORT (NAME, DATUMZEIT, ZEIT_MS, WERT, STATUS) VALUES ('ST70_PM701_PRODUCTPACKING', SYSDATE, 0, '%s', 0)" %(wert),"DB_TEST") #Sending a telegram to the test base system.tag.writeBlocking(["[default]St70/Pm701/WriteDone"],[1]) #Send a signal WriteDone if prod == 1 and prodConnection == 1: #Are we writing to the production base and is there a connection to the production base system.db.runUpdateQuery("INSERT INTO QMES_QOPC_IMPORT (NAME, DATUMZEIT, ZEIT_MS, WERT, STATUS) VALUES ('ST70_PM701_PRODUCTPACKING', SYSDATE, 0, '%s', 0)" %(wert),"DB_TEST") #Send a telegram to the database system.tag.writeBlocking(["[default]St70/Pm701/WriteDone"],[1]) #Send a signal WriteDone if currentValue.value == 0: #Reset of WriteRequest by PLC system.tag.writeBlocking(["[default]St70/Pm701/WriteDone"],[0]) #Reset WriteDone ``` We measured the time by enableing History on both tags. ![image](https://us1.discourse-cdn.com/inductiveautomation/original/3X/c/6/c6c5db29bd802ad2e9b0081806ca08e82304563c.png) In previous projects made in Zenon, similar operations took less than 50ms. Is there any way to improve the time of script execution? ---
**Author:** ![JordanCClark](https://sea1.discourse-cdn.com/inductiveautomation/user_avatar/forum.inductiveautomation.com/jordancclark/32/83362_2.png) [@JordanCClark](https://forum.inductiveautomation.com/u/JordanCClark)\ **Post date:** [April 29, 2022, 10:21am UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040/2 "2022-04-29T10:21:05Z")
You can try combining your tag read and write operations. I also suggest using a logger to measure the script execution. You can also add more points using nanoTime() to see which portion of the script is taking longer. ```python from java.lang.System import nanoTime(). start = nanoTime() logger = system.util.getLogger('myLogger') tagListIn = [ "[default]St70/Pm701/ST70_PM701_PRODUCTPACKING.value", "[default]St70/Pm701/PisanieDoBazyProdukcyjnej.value", "[default]St70/Pm701/PisanieDoBazyTestowej.value", "[default]AvailabilityDBTest.value", "[default]AvailabilityDBProd.value" ] tagListOut = ["[default]St70/Pm701/WriteDone"] query = "INSERT INTO QMES_QOPC_IMPORT (NAME, DATUMZEIT, ZEIT_MS, WERT, STATUS) VALUES ('ST70_PM701_PRODUCTPACKING', SYSDATE, 0, '%s', 0)" trigger = currentValue.value writeDoneValue = 0 if trigger: wert, prod, test, testConnection, prodConnection = [tag.value for tag in system.tag.readBlocking(tagListIn)] if test and testConnection: system.db.runUpdateQuery(query % (wert), 'DB_TEST') writeDoneValue = 1 if prod and prodConnection: system.db.runUpdateQuery(query % (wert), 'DB_PROD') writeDoneValue = 1 system.tag.writeBlocking(["[default]St70/Pm701/WriteDone"],[writeDoneValue]) end = nanoTime() logger.info('Execution time was {} ms'.format((end - start)/10000000.0)) #Execution time in ms. ``` ---
**Author:** ![T\_Hat](https://avatars.discourse-cdn.com/v4/letter/t/df705f/32.png) [@T\_Hat](https://forum.inductiveautomation.com/u/T_Hat)\ **Post date:** [April 29, 2022, 11:49am UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040/3 "2022-04-29T11:49:55Z")
Thank you very much, execution time has decreased to 15-16ms. I had to remove part of the script used to measure execution time, to run the script. Do i need to install additional libraries to use it? ---
**Author:** ![JordanCClark](https://sea1.discourse-cdn.com/inductiveautomation/user_avatar/forum.inductiveautomation.com/jordancclark/32/83362_2.png) [@JordanCClark](https://forum.inductiveautomation.com/u/JordanCClark)\ **Post date:** [April 29, 2022, 12:04pm UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040/4 "2022-04-29T12:04:19Z")
Oops. The import line shouldn’t have parenthesis. ```auto from java.lang.System import nanoTime ``` ---
**Author:** ![pascal.fragnoud](https://sea1.discourse-cdn.com/inductiveautomation/user_avatar/forum.inductiveautomation.com/pascal.fragnoud/32/24728_2.png) [@pascal.fragnoud](https://forum.inductiveautomation.com/u/pascal.fragnoud)\ **Post date:** [April 29, 2022, 12:44pm UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040/5 "2022-04-29T12:44:05Z")
I’d suggest one change: instead of assigning 1 to writeDoneValue, use the return of the query (which should be the number of affected rows), and maybe replace `runUpdateQuery` with `runPrepUpdate`. Also, but that’s… a personal thing, I’d rather avoid using just `if test` if I’m looking specifically for `test == 1`, but there’s not enough context to know what values those variables can take. If they can only be 0 or 1, then I’d suggest making them explicit booleans. ---
**Author:** ![JordanCClark](https://sea1.discourse-cdn.com/inductiveautomation/user_avatar/forum.inductiveautomation.com/jordancclark/32/83362_2.png) [@JordanCClark](https://forum.inductiveautomation.com/u/JordanCClark)\ **Post date:** [April 29, 2022, 1:15pm UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040/6 "2022-04-29T13:15:11Z")
There’s enough context to assume boolean with the picture at the top of his post. It’s easy to miss, as I had to look closer for it. 😉 I generally use flags like writeDoneValue, because it’s explicit, and, while I didn’t put any real comments in this snippet, I try to write my code as if the guy maintaining it after me is a serial killer who knows where I live. ---
**Author:** ![bkarabinchak.psi](https://sea1.discourse-cdn.com/inductiveautomation/user_avatar/forum.inductiveautomation.com/bkarabinchak.psi/32/83567_2.png) [@bkarabinchak.psi](https://forum.inductiveautomation.com/u/bkarabinchak.psi)\ **Post date:** [April 29, 2022, 1:24pm UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040/7 "2022-04-29T13:24:41Z")
> [@JordanCClark](#): > > I try to write my code as if the guy maintaining it after me is a serial killer who knows where I live. This is a good policy. Especially if the person reading it 6 months from now who wants to kill the original author is yourself 🙃 ---
**Author:** ![pascal.fragnoud](https://sea1.discourse-cdn.com/inductiveautomation/user_avatar/forum.inductiveautomation.com/pascal.fragnoud/32/24728_2.png) [@pascal.fragnoud](https://forum.inductiveautomation.com/u/pascal.fragnoud)\ **Post date:** [April 29, 2022, 4:22pm UTC](https://forum.inductiveautomation.com/t/tag-event-scripts-on-value-changed-slow-execution-time/59040/8 "2022-04-29T16:22:20Z")
> [@JordanCClark](#): > > I generally use flags like writeDoneValue, because it’s explicit, and, while I didn’t put any real comments in this snippet, I try to write my code as if the guy maintaining it after me is a serial killer who knows where I live. I'm not suggesting to get rid of the flag, but to assign it the return of the query instead of a constant. So that you know the write was succesful. And maybe cast it to a boolean.