Just upgraded from v7.9.21 to v8.1.48 and am working through migration stuff.
If I make a module, such as shared.foo in the global project and then try to run from shared.foo import * from another module, shared.bar, the following gets imported even though the shared.foo is empty:
{'getDict', 'setName', 'dict', 'getCode', 'toString', 'path', 'getPath', 'reloadModule', 'code', 'getName', 'setCode', 'loadModule', 'name'}
It appears IA added these methods/attributes into modules at some point in these newer versions, which breaks existing code making use of import * with modules without __all__ defined.
The most immediate issue with this design is that dict is a builtin and is being overridden with a dictionary instance, which is breaking attempts to:
- make a dictionary using
dict()call - isinstance(object, dict) calls because dict is now a dictionary instance
Is there a way to change the way import * works so it does not include a bunch of stuff not actually visible in the module being imported from?
Or any way to remove these methods/attributes from module namespaces, at the very least the attributes which seem likely to conflict with things in the module i am importing into?
If not, I can see the following workarounds for my codebase:
- use
__all__in every module I am usingimport *with.__all__is already used for some of them and avoids importing this stuff. - rewrite all
import *statements in codebase to specifically identify objects needed. This is probably impractical due to design decisions made previously and the breadth of the codebase.
These solutions are not ideal as it will eat up some time to go through the existing code and we always run the risk of accidentally missing something somewhere or making the mistake again in the future.
Any suggestions would be appreciated.
UPDATE: tested in Script Console, from shared.foo import * and dict is not overridden. Issue somehow seems specific to when one module imports another module.
Thanks,