Syntax Highlighting: Set()

dkhayes117 · October 7, 2022, 12:22pm

Not a big deal, but I'm just wondering why list(), len(), etc. are highlighted yellow, but set() isn't.

bkarabinchak.psi · October 7, 2022, 12:48pm

Everyone and their mom knows list and len but only real heads use set is my personal conspiratorial reason for this.

PGriffith · October 7, 2022, 2:35pm

github.com

bobbylight/RSyntaxTextArea/blob/master/RSyntaxTextArea/src/main/java/org/fife/ui/rsyntaxtextarea/modes/PythonTokenMaker.flex#L276-L341


      
              /* Standard functions */
          	"abs" |
          	"apply" |
          	"bool" |
          	"buffer" |
          	"callable" |
          	"chr" |
          	"classmethod" |
          	"cmp" |
          	"coerce" |
          	"compile" |
          	"complex" |
          	"delattr" |
          	"dict" |
          	"dir" |
          	"divmod" |
          	"enumerate" |
          	"eval" |
          	"execfile" |
          	"file" |

This file has been truncated. show original

Could open a PR

pturmel · October 7, 2022, 2:52pm

Any reason you don't iterate through the built-ins to auto-populate this list?

PGriffith · October 7, 2022, 3:55pm

Not my code. It's meant to run without any Jython or Python environment, hence the hardcoded list. I think it not being a complete hardcoded list is just an oversight by the primary dev.
I could extend/reimplement this class in Ignition, but then I'm taking on that maintenance debt. Easier to push changes upstream, which I'll probably do at some point.